<html>
<head><meta charset="utf-8"><title>bors r=me when CI passes · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html">bors r=me when CI passes</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="211853690"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211853690" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211853690">(Sep 30 2020 at 23:43)</a>:</h4>
<p>I notice that reviewers often say "r=me when CI passes". Can't you just <code>r+</code> before CI passes and then if it fails bors will stop the merge?</p>



<a name="211853722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211853722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211853722">(Sep 30 2020 at 23:44)</a>:</h4>
<p>Bors will still run tests again when CI fails</p>



<a name="211853771"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211853771" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211853771">(Sep 30 2020 at 23:44)</a>:</h4>
<p>And that blocks the queue for however many minutes it takes for them to fail again</p>



<a name="211853827"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211853827" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211853827">(Sep 30 2020 at 23:45)</a>:</h4>
<p>Could bors be changed so that it waits until CI passes before merge-testing?</p>



<a name="211855642"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211855642" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211855642">(Oct 01 2020 at 00:12)</a>:</h4>
<p>the problem is that sometimes CI can fail spuriously, so one doing the "r=&lt;name&gt;" can check the reason and r+ if it is spurious or not</p>



<a name="211856569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211856569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211856569">(Oct 01 2020 at 00:26)</a>:</h4>
<p><code>r+ yield</code> or something like that could be useful</p>



<a name="211856768"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211856768" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211856768">(Oct 01 2020 at 00:30)</a>:</h4>
<p>I think it should be <code>r+ await</code> but otherwise agree <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span></p>



<a name="211859174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211859174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211859174">(Oct 01 2020 at 01:11)</a>:</h4>
<p>we could but bors is a bit dumb at this stage, even to yield to another pr of higher priority we often have to <code>@bors retry</code> it even though we don't want to retry it <span aria-label="stuck out tongue" class="emoji emoji-1f61b" role="img" title="stuck out tongue">:stuck_out_tongue:</span></p>



<a name="211859191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211859191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211859191">(Oct 01 2020 at 01:11)</a>:</h4>
<p>also github search isn't much helpful as I often try to search for <code>r=me</code> and it doesn't work that way</p>



<a name="211865415"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211865415" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211865415">(Oct 01 2020 at 03:22)</a>:</h4>
<p>Yeah, it'd be nice to have more features in bors to manage review and similar.</p>



<a name="211868752"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211868752" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211868752">(Oct 01 2020 at 04:40)</a>:</h4>
<p>I think I heard someone was working on a bors rewrite in rust with more features?</p>



<a name="211887340"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211887340" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211887340">(Oct 01 2020 at 09:38)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116883">tmandry</span> <a href="#narrow/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes/near/211868752">said</a>:</p>
<blockquote>
<p>I think I heard someone was working on a bors rewrite in rust with more features?</p>
</blockquote>
<p>yeah, here it is: <a href="https://github.com/bors-rs/bors">https://github.com/bors-rs/bors</a></p>



<a name="211987514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211987514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211987514">(Oct 01 2020 at 23:13)</a>:</h4>
<p>That sounds cool!</p>



<a name="211989844"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/bors%20r%3Dme%20when%20CI%20passes/near/211989844" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/bors.20r.3Dme.20when.20CI.20passes.html#211989844">(Oct 01 2020 at 23:48)</a>:</h4>
<p>yeh but it's still "early phases" atm</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>